Ive never played a rogue past level 19 so I cant really comment but I recently switched to a warrior main and I love it.
I dont PvP much anymore (got WSG Exalted while leveling) but I am one of the 3 main tanks for my new guild. I really enjoy main tanking and don't think I'll be switching to anything else. Ive played both a a healer (shaman for 1.5years) and DPS (hunter alt which Ive raided with on a number of occasions), neither can hold a torch to my warrior in my raid fun factor.
As far as PvP goes, warriors are pretty gimped against a lot of the caster/kitting classes but VERY fun if you have a heal bot following you around, specially a shaman. -- "The man who thinks he can and the man who thinks he can't, are both right. Which one are you?"
It really does not matter, most of these opinions are based on pre BC. In two months this will all be obsolete. In BC it is going to be very easy for you to obtain quality gear at least in the beginning and with arenas/pvp never be far behind the raiders.
So play whatever you think will be the most fun, depending on the situation and gear a fury/arms warrior can out dps rogues.
Both are fun classes and besides having melee as a main attack are very different play styles. -- The History Channel rocks! ... you know it!