Cudni
La Merma - Vigilado
Premium,MVM
join:2003-12-20
Someshire
| reply to Ryan F
Re: [FireFox] BBR Firefox Extension
Hi
I wonder, if at all possible and you have time, to add a notification when a thumbs up is given to your extention. It could help with this little request 
»Dates for thumbs up on posts (take 2)
It is just an idea, a shot in the dark
Cudni
--
....nothing but a well informed optimistHelp yourself so God can help you |
|
Ryan F
Take Back The Web
Premium
join:2002-10-18
Alexandria, VA | reply to Morac
Ah, thanks
I didn't even notice that onAlertClickCallback wasn't working anymore as I didn't have the sliders enabled. |
|
Morac
join:2001-08-30
Riverside, NJ
 ·Comcast
4 edits | reply to Ryan F
Just a FYI, but clicking on the alerts that pop up in the bottom right corner no longer work in FireFox 1.5 Beta.
This is because the way alerts work changed. In Mozilla 1.7, when the user clicked an alert or the alert disappeared on its own the onAlertClickCallback and onAlertFinished would be called respectively.
This was depreciated in Firefox 1.0 for an observer method. When an alert is clicked the observe function is called with aTopic set to "alertclickcallback", when the alert goes away it sets aTopic to "alertfinished". aData contains the cookie data.
In Firefox 1.0.x either method worked, in Firefox 1.5 it appears only the later method works.
Inserting the following function at the end of the alertSlide variable in dslrOverlay.js will fix this problem in Firefox 1.5 while retaining compatibility with older versions. The first and last line are existing lines, the second line is a modified line. All the other lines are new.
}
},
/////////////////////////////
// nsIObserver
observe: function(aSubject, aTopic, aData)
{
if (aTopic == "alertclickcallback")
{
var imAlert = dslrPref.getBoolPref("imFlag");
var topAlert = dslrPref.getBoolPref("newsFlag");
if (imAlert == true) {
dslrGoTo(false,1,false);
killNotify(1,false,false)
}
if (topAlert == true) {
dslrGoTo(false,false,1);
killNotify(false,1,false)
}
}
}
}
I'm also attaching the updated dslrOverlay.js file since I think it's easier to read that because the formatting is lost in the post.
edit: there was a bug in the version I previously posted. It is fixed now.
--
The Comcast Disney Avatar has been retired. |
|
Brano
I hate Vogons
Premium,MVM
join:2002-06-25
Burlington, ON
 ·TekSavvy Solutions..
| reply to Ryan F
Hope Ryan F  won't mind but I took the liberty and modified 0.9 to work with Firefox 1.5 beta2. |
|
Maarvin
Premium
join:2005-04-11
Denver, CO | reply to Ryan F
Thanks for reminding me, Ryan. I've got it, thanks much. 
-Mike |
|
mers2
Premium,MVM
join:2004-03-20
USA
clubs:
1 edit | reply to Ryan F
NM just saw the announcement. |
|
Ryan F
Take Back The Web
Premium
join:2002-10-18
Alexandria, VA | reply to Maarvin
You've already asked this question: »[FireFox] BBR Firefox Extension |
|
Maarvin
Premium
join:2005-04-11
Denver, CO
·Comcast
| reply to Ryan F
Well Ah! Thanks anyway Ryan, but there appears to be nothing to download at the address you gave in your original posting. I would have liked that extension if it were still available.
-Mike
--
Never let your sense of morals prevent you from doing what is right. |
|
Ryan F
Take Back The Web
Premium
join:2002-10-18
Alexandria, VA
2 edits | reply to Morac
All that needs to be done is bump the max-version to 1.4. The chrome manifest is already created during installation.
And as for sanity checks, they're done only where needed. The only element that truly disappears is the toolbar icon and checks are already done there.
I've had version 0.9 (which works with the latest beta) sitting in U.M.O's approval queue for around two weeks now 
I'm going to submit a bug report on that this afternoon.
Heck, it's been so long since I submitted it I've already started on 1.0 - using the new PrefWindow XUL objects.
|
|
Morac
join:2001-08-30
Riverside, NJ
·Comcast
| reply to Ryan F
Is this being updated for Firefox 1.5? As far as I can tell the only change needed is to update the install.rdf file and create a manifest.
Though I think the code needs some sanity checks, because when I tried the above I would periodically get errors messages when the extensions tried to act on objects that didn't exist. For example doing a getElementById call and then immediately accessing that object without checking to see if it exists or not.
--
The Comcast Disney Avatar has been retired. |
|
Weirdal
Premium
join:2003-06-28
Lincoln, NE | reply to Sandman5
it doesn't |
|
Sandman5
Premium
join:2002-07-10
Brookline, MO
clubs: | reply to Weirdal
Well technically the smiley was outside of the code so I would think it should work.
--
Rule #62: Don't take yourself so damn seriously! |
|
Weirdal
Premium
join:2003-06-28
Lincoln, NE | reply to Sandman5
smilies dont work with code |
|
Sandman5
Premium
join:2002-07-10
Brookline, MO
clubs:
2 edits | reply to Ryan F
Now my reportstatus.xml says
<err str="not logged in"/>
:) Come on, what gives?
Edit: By looking at my smileys it looks like there might be something else going on.
--
Rule #62: Don't take yourself so damn seriously! |
|
neill
join:2000-11-15
Irvington, NY
| reply to Ryan F
Notifier 0.8.9 has still been working inconsistently for me. Sometimes, after I clear the followed threads, new ones don't show up. At others, I start FF, and the envelope icon doesn't show, so I close/reopen and it appears.
Deleting the xul.mfl file and reopening seems at least to be a temporary fix-- then I'm good to go for at least a few sessions.
I've been using the most recent stable builds of FF, Stipe, and Moox. |
|
JAAulde
yum yum yum yum yum
Premium,MVM
join:2001-05-09
Hagerstown, MD
| reply to Ryan F
Ok, now it is showing 2 updated topics when I only have one in the followed list. And 1 when I have nothing showing.
So we are definitely back to where I can use the offset feature, or go find the old one that is causing the reportstatus to show 1.
--
Long my imprisoned spirit lay, Fast bound in sin and nature’s night;
Thine eye diffused a quickening ray—I woke, the dungeon flamed with light;
My chains fell off, my heart was free, I rose, went forth, and followed Thee. |
|
JAAulde
yum yum yum yum yum
Premium,MVM
join:2001-05-09
Hagerstown, MD
| reply to Ryan F
said by Ryan F :I'll let Justin know about this. Awesome. Thanks a lot.
Jim |
|
Ryan F
Take Back The Web
Premium
join:2002-10-18
Alexandria, VA | reply to JAAulde
That's quite odd. I'll let Justin know about this. |
|
JAAulde
yum yum yum yum yum
Premium,MVM
join:2001-05-09
Hagerstown, MD
| reply to Ryan F
My reportstatus.xml now says
<m n="1 updated topics"/>
Now, let me clarify before anyone says this is a known problem and that I should click 'stop' on each thread or use the offset. It tells me '1 updated topics' when I have nothing in my followed list, AND when I have 1 topic listed in my followed list. It would seem that if this was a problem with one of the old topics, that when I actually have a topic in my followed list that the reportstatus.xml would say '2 updated topics' instead of 1.
Regardless, with this anomaly, the offset feature is now useless. If I set it to 1, and a topic appears in my followed list, I do not get notified.
I know this is a problem with the code on the site which generates reportstatus.xml and not the extension itself, but I figured I would report the oddity.
Thanks,
Jim
--
Long my imprisoned spirit lay, Fast bound in sin and nature’s night;
Thine eye diffused a quickening ray—I woke, the dungeon flamed with light;
My chains fell off, my heart was free, I rose, went forth, and followed Thee. |
|
Ryan F
Take Back The Web
Premium
join:2002-10-18
Alexandria, VA | reply to Vamp
No. You're only counted as being online if you're actively browsing the site. |
|
