Morac
join:2001-08-30
Riverside, NJ
 ·Comcast
4 edits | reply to Ryan F
Re: [FireFox] BBR Firefox Extension
Just a FYI, but clicking on the alerts that pop up in the bottom right corner no longer work in FireFox 1.5 Beta.
This is because the way alerts work changed. In Mozilla 1.7, when the user clicked an alert or the alert disappeared on its own the onAlertClickCallback and onAlertFinished would be called respectively.
This was depreciated in Firefox 1.0 for an observer method. When an alert is clicked the observe function is called with aTopic set to "alertclickcallback", when the alert goes away it sets aTopic to "alertfinished". aData contains the cookie data.
In Firefox 1.0.x either method worked, in Firefox 1.5 it appears only the later method works.
Inserting the following function at the end of the alertSlide variable in dslrOverlay.js will fix this problem in Firefox 1.5 while retaining compatibility with older versions. The first and last line are existing lines, the second line is a modified line. All the other lines are new.
}
},
/////////////////////////////
// nsIObserver
observe: function(aSubject, aTopic, aData)
{
if (aTopic == "alertclickcallback")
{
var imAlert = dslrPref.getBoolPref("imFlag");
var topAlert = dslrPref.getBoolPref("newsFlag");
if (imAlert == true) {
dslrGoTo(false,1,false);
killNotify(1,false,false)
}
if (topAlert == true) {
dslrGoTo(false,false,1);
killNotify(false,1,false)
}
}
}
}
I'm also attaching the updated dslrOverlay.js file since I think it's easier to read that because the formatting is lost in the post.
edit: there was a bug in the version I previously posted. It is fixed now.
--
The Comcast Disney Avatar has been retired. |
Cudni
La Merma - Vigilado
Premium,MVM
join:2003-12-20
Someshire
| reply to Ryan F
Hi
I wonder, if at all possible and you have time, to add a notification when a thumbs up is given to your extention. It could help with this little request 
»Dates for thumbs up on posts (take 2)
It is just an idea, a shot in the dark
Cudni
--
....nothing but a well informed optimistHelp yourself so God can help you |
